-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for ECMAScript modules #239
Conversation
9c0d590
to
fd4effd
Compare
Ended up removing a lot of the |
Looks like we may not need to the python3 install at all. |
I also did the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great step towards ESM support!
6fa384e
to
9159cd1
Compare
e587d28
to
133d104
Compare
ee18559
to
fb005fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thx for the contribution!
The last PR #239 should have included these changes to begin with, somehow they got lost on the wire. The introduction of a new interface called `FuzzTarget` caused a name conflict with a similarly named struct field within `options`. This PR ships a change that resolves this conflict.. whoops 🧐 Authored-by: 0xricksanchez <christopher.krah@code-intelligence.com>
This is not yet a full solution as full ES6 projects won't get instrumented yet.
Loading projects that (partially) rely on ES6 won't crash anymore though
Note: A follow up PR will attempt to resolve the remaining problems