-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a verbose flag for debug output #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I have some minor comments!
I intentionally left it as a draft for now as I still wasn’t quite content with the current implementation. I wanted to address this in another refactoring and by adding more tests asap. Thanks for the comments I’ll incorporate the feedback 👍 |
bc84443
to
136a8e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR the users can easily check if their custom hooks are applied or not. Thanks for this great contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last bit that's missing is documentation!
bebcb88
to
f65c07f
Compare
Added a short section to the docs for both the verbose logging option and the debug-ability of custom hooks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
743e45f
to
e6395f9
Compare
This allows easier debugging of, e.g., custom bug detectors/hooks and can serve as an entry point for future debug features we do not want to have enabled by default.