Fix prebuild upload on windows

Prebuild upload needs a GitHub access token to upload artifacts to a GitHub release. This token was provided via an environment variable, which broke on windows due to a different env var access format string. To only use one upload script command, the token is now passed in as additional argument after "--". This way the upload works on all operating systems.
CodeIntelligenceTesting · Sep 15, 2022 · 265c929 · 265c929
1 parent 74fd382
commit 265c929
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/prerelease.yaml b/.github/workflows/prerelease.yaml
@@ -69,6 +69,6 @@ jobs:
       - name: install dependencies
         run: npm install --ws=@jazzer.js/fuzzer
       - name: build and upload prebuilds
-        run: npm run upload --workspace=@jazzer.js/fuzzer
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
+        run: >
+          npm run upload --workspace=@jazzer.js/fuzzer --
+          ${{secrets.GITHUB_TOKEN}}
diff --git a/packages/fuzzer/package.json b/packages/fuzzer/package.json
@@ -17,7 +17,7 @@
 	"types": "dist/fuzzer.d.ts",
 	"scripts": {
 		"prebuild": "prebuild --runtime napi --backend cmake-js --all --strip --verbose",
-		"upload": "prebuild --runtime napi --backend cmake-js --all --strip --upload ${GITHUB_TOKEN}",
+		"upload": "prebuild --runtime napi --backend cmake-js --all --strip --upload",
 		"install": "prebuild-install --runtime napi || cmake-js rebuild --out build",
 		"build": "cmake-js compile --out build",
 		"format:fix": "clang-format -i *.cpp shared/*.cpp shared/*.h",