Introduce toggle for FuzzedDataProvider to only return printable strings #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xricksanchez
force-pushed
the
FUZZ-490_enforce_printable_string
branch
from
3cd5c13
to
5f1a5fa
Compare
0xricksanchez
changed the title
0xricksanchez
force-pushed
the
FUZZ-490_enforce_printable_string
branch
from
2d9ceec
to
dbbcdfe
Compare
0xricksanchez
force-pushed
the
FUZZ-490_enforce_printable_string
branch
from
7ba43c0
to
c3addb6
Compare
0xricksanchez
force-pushed
the
FUZZ-490_enforce_printable_string
branch
from
509447a
to
58053d9
Compare
oetr
reviewed
Jan 25, 2023
oetr
approved these changes
Jan 25, 2023
|
@oetr What do you think of this approach, which should yield a more uniform distribution when converting to ASCII printable? |
0xricksanchez
force-pushed
the
FUZZ-490_enforce_printable_string
branch
from
278f6eb
to
4791123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change aims at being able to toggle this individually for each time we call a
ConsumeStr*method, which would allow us to pass lossy strings and proper ASCII strings as function inputs, instead of globally toggling ASCII-only mutations by setting the appropriate libfuzzer flag and/or using the constructor for the FuzzedDataProviderInstead of just filtering out non-printable ones and having to re-read from the data buffer (multiple times) I opted for a (hopefully lightweight) conversion, so that each non-printable one is converted into a printable one.