Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Sync File Id Strategy #280

Merged
merged 22 commits into from
Jan 24, 2023
Merged

Edge Sync File Id Strategy #280

merged 22 commits into from
Jan 24, 2023

Conversation

kyakdan
Copy link
Member

@kyakdan kyakdan commented Jan 16, 2023

No description provided.

@kyakdan kyakdan changed the title Fuzz 506 edge id sync file Edge Sync File Id Strategy Jan 16, 2023
@kyakdan kyakdan force-pushed the FUZZ-506-edge-id-sync-file branch 4 times, most recently from 6974c75 to 8502b09 Compare January 19, 2023 09:57
@kyakdan kyakdan requested a review from a team January 19, 2023 09:57
@kyakdan kyakdan marked this pull request as ready for review January 19, 2023 09:58
packages/fuzzer/fuzzer.ts Outdated Show resolved Hide resolved
packages/fuzzer/coverage.ts Outdated Show resolved Hide resolved
packages/fuzzer/fuzzer.ts Outdated Show resolved Hide resolved
packages/fuzzer/fuzzer.ts Outdated Show resolved Hide resolved
packages/fuzzer/fuzzer.ts Outdated Show resolved Hide resolved
packages/instrumentor/edgeIdStrategy.ts Outdated Show resolved Hide resolved
packages/instrumentor/edgeIdStrategy.ts Outdated Show resolved Hide resolved
packages/instrumentor/edgeIdStrategy.ts Outdated Show resolved Hide resolved
packages/instrumentor/edgeIdStrategy.ts Outdated Show resolved Hide resolved
packages/core/cli.ts Show resolved Hide resolved
@bertschneider
Copy link
Contributor

I reviewed commit by commit and noticed too late, that some comments were on already changed code. Everything should still be valid, I hope, but that's why code on some comments is marked as outdated.

@kyakdan kyakdan force-pushed the FUZZ-506-edge-id-sync-file branch 3 times, most recently from 3efa070 to 27b5228 Compare January 23, 2023 08:40
@kyakdan kyakdan enabled auto-merge (rebase) January 23, 2023 08:40
packages/instrumentor/edgeIdStrategy.ts Outdated Show resolved Hide resolved
packages/instrumentor/edgeIdStrategy.ts Show resolved Hide resolved
packages/instrumentor/instrument.ts Outdated Show resolved Hide resolved
packages/instrumentor/plugins/codeCoverage.test.ts Outdated Show resolved Hide resolved
packages/fuzzer/fuzzer.ts Outdated Show resolved Hide resolved
@kyakdan kyakdan force-pushed the FUZZ-506-edge-id-sync-file branch 2 times, most recently from d1c94f6 to dae72f3 Compare January 23, 2023 16:02
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

The previous implementation did not use the first slot of the coverage
map. The first edge ID returned was 1.
and a memory-sync implementation. The implemented policy is a
refactoring of the current edge ID generation approach that should be
used when fuzzing using a single process.
This removes duplicate type definitions and makes it clear when calling
functions from the native addon from the other packages.
packages/instrumentor/instrument.test.ts Show resolved Hide resolved
packages/instrumentor/instrument.ts Outdated Show resolved Hide resolved
packages/instrumentor/instrument.ts Outdated Show resolved Hide resolved
This is a first step to simplify the interface to the instrumentor
package and makes testing easier.
@kyakdan kyakdan merged commit bacf244 into main Jan 24, 2023
@kyakdan kyakdan deleted the FUZZ-506-edge-id-sync-file branch January 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants