-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge Sync File Id Strategy #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 16, 2023 16:43
4213e17
to
58e8001
Compare
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
4 times, most recently
from
January 19, 2023 09:57
6974c75
to
8502b09
Compare
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 19, 2023 10:00
8502b09
to
3d44b99
Compare
I reviewed commit by commit and noticed too late, that some comments were on already changed code. Everything should still be valid, I hope, but that's why code on some comments is marked as outdated. |
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
3 times, most recently
from
January 23, 2023 08:40
3efa070
to
27b5228
Compare
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
2 times, most recently
from
January 23, 2023 16:02
d1c94f6
to
dae72f3
Compare
bertschneider
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement!
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 24, 2023 04:16
9b1c9c3
to
2c16a2e
Compare
The previous implementation did not use the first slot of the coverage map. The first edge ID returned was 1.
and a memory-sync implementation. The implemented policy is a refactoring of the current edge ID generation approach that should be used when fuzzing using a single process.
This removes duplicate type definitions and makes it clear when calling functions from the native addon from the other packages.
This way, these functions will have access to `EdgeIdStrategy` object
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 24, 2023 08:27
2c16a2e
to
0a63c76
Compare
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 24, 2023 09:09
0a63c76
to
1acda3a
Compare
This strategy is only used for testing purposes
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 24, 2023 11:07
1acda3a
to
af8f146
Compare
This is a first step to simplify the interface to the instrumentor package and makes testing easier.
kyakdan
force-pushed
the
FUZZ-506-edge-id-sync-file
branch
from
January 24, 2023 12:10
af8f146
to
e36b000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.