-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzztests: check error code of each individual fuzztest #297
Conversation
I "fixed" the pipeline and the failing tests. Locally the script runs without issues. |
libfuzzer has a SIGALARM handler that is triggered IFF a timeout has been given to the libfuzzer invocation via The default is quite high already, like over a 1000secs AFAIK. I am uncertain if we set some smaller value anywhere, from the top of my head, rn. |
Looks like const timeout = currentTimeout();
const corpus = new Corpus(testFile, testStatePath);
const fuzzingConfig = loadConfig();
// CHANGED
fuzzingConfig.timeout = 100000; //timeout; |
The |
I see that in that fuzz test, |
@oetr Ah, yes. Timeouts should be handled differently, depending on the execution mode, but probably aren't. |
e3c485a
to
4dd38b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks very good. I've left a single comment to make the timeout flag consistent with libFuzzer.
a74d4b0
to
af92df2
Compare
Really good addition and fix! Could you please add parenthesis around |
6bb7e56
to
97dbadd
Compare
97dbadd
to
074745b
Compare
Now failed fuzz tests will be recognized as such, and the GitHub pipeline will fail.
New feature: fuzz tests now support timeouts.