Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary excluded flag on CLI #316

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Remove unnecessary excluded flag on CLI #316

merged 3 commits into from
Feb 13, 2023

Conversation

0xricksanchez
Copy link
Contributor

This eliminates the need to specify something like -e nothing.

@0xricksanchez 0xricksanchez requested a review from a team February 9, 2023 10:48
bertschneider
bertschneider reviewed Feb 9, 2023
View reviewed changes
packages/core/core.ts Outdated Show resolved Hide resolved
packages/core/core.ts Outdated Show resolved Hide resolved
docs/fuzz-targets.md Outdated Show resolved Hide resolved
bertschneider
bertschneider reviewed Feb 10, 2023
View reviewed changes
packages/instrumentor/instrument.ts Show resolved Hide resolved
packages/core/core.ts Outdated Show resolved Hide resolved
packages/instrumentor/instrument.ts Outdated Show resolved Hide resolved
bertschneider
bertschneider approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx! Could you squash the commits during merge?

@0xricksanchez 0xricksanchez added this pull request to the merge queue Feb 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2023
@0xricksanchez 0xricksanchez added this pull request to the merge queue Feb 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2023
@0xricksanchez 0xricksanchez added this pull request to the merge queue Feb 13, 2023
Merged via the queue into main with commit ee5edb5 Feb 13, 2023
@0xricksanchez 0xricksanchez deleted the FUZZ-546_cleanup_cli branch February 13, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertschneider bertschneider bertschneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xricksanchez @bertschneider