-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Jest fuzz tests written in TypeScript #449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertschneider
force-pushed
the
FUZZ-567-jest-typescript
branch
3 times, most recently
from
May 26, 2023 06:47
531cea1
to
5713036
Compare
oetr
reviewed
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a great contribution, thank you! I only have some minor remarks.
bertschneider
force-pushed
the
FUZZ-567-jest-typescript
branch
3 times, most recently
from
June 2, 2023 14:20
9d421d4
to
c8e5d2d
Compare
Jest script transformer uses the configured Jest extensions, like ts-jest, and allows us to load more file formats.
Loaded sources could already contain inline source maps, e.g. if they were loaded by ts-jest, which need to be forwarded to the internal transformers. Otherwise the resulting coverage report would be off.
bertschneider
force-pushed
the
FUZZ-567-jest-typescript
branch
from
June 15, 2023 13:52
c8e5d2d
to
c6667cd
Compare
oetr
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many projects in the JavaScript ecosystem are actually developed in TypeScript. Usually these projects use Jest to directly execute tests also written in TypeScript via appropriate on-the-fly transpilers (e.g. ts-jest).
To prevent a dedicated transpilation step of the tests when using Jazzer.js, support for directly executing Jest fuzz tests written in TypeScript is added.