Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: deep-copy default Jest config #451

Merged
merged 1 commit into from
May 26, 2023

Conversation

oetr
Copy link
Contributor

@oetr oetr commented May 25, 2023

This fixes the bug where a Jest-fuzztest would write a crash file into the directory of another Jest-fuzztest. The bug was due to 1) each test adds --artifact_prefix=... to its copy of the options, 2) the copy provided to each test was a shallow-copy of defaultOptions. Making deep copies of the default options fixes this problem.

@oetr oetr requested a review from a team May 25, 2023 11:45
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bertschneider bertschneider force-pushed the FUZZ-699-jest-runner-crash-files-bugfix branch from a24223e to afe6203 Compare May 26, 2023 09:06
@bertschneider bertschneider enabled auto-merge (rebase) May 26, 2023 09:06
@bertschneider bertschneider merged commit 0279aac into main May 26, 2023
6 checks passed
@bertschneider bertschneider deleted the FUZZ-699-jest-runner-crash-files-bugfix branch May 26, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants