Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Use wording from jazzer for logging corpus inputs on startup #469

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

zgtm
Copy link
Member

@zgtm zgtm commented Jun 9, 2023

No description provided.

@zgtm zgtm requested a review from a team June 9, 2023 15:52
@zgtm
Copy link
Member Author

zgtm commented Jun 9, 2023

Oh, btw. further down in line 273 I've seen that we use console.error to log info messages. I guess this should be converted to use stderr as well … (as jazzer also does)

@bertschneider
Copy link
Contributor

True, we eventually have to build some kind of logging abstraction. Perhaps now is the time 🤔

@zgtm zgtm force-pushed the FUZZ-691-log-corpus-directories-reword-log-message branch from dccf6ac to 6127640 Compare June 12, 2023 11:34
Also changes info logging from printing to stdout to printing tostderr in two cases.
@zgtm zgtm force-pushed the FUZZ-691-log-corpus-directories-reword-log-message branch from 6127640 to f8447cb Compare June 12, 2023 12:53
@zgtm zgtm enabled auto-merge (rebase) June 12, 2023 12:58
@zgtm zgtm merged commit 515395c into main Jun 12, 2023
6 checks passed
@zgtm zgtm deleted the FUZZ-691-log-corpus-directories-reword-log-message branch June 12, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants