tests: fix flaky signal handling tests #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oetr
force-pushed
the
FUZZ-762_fix_flaky_tests
branch
from
25ff0ba
to
cefb18c
Compare
bertschneider
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synchronous tests in
signal_handlerscheck that a certain string is not printed after a fuzz target was "killed" by a SIGINT or SIGSEGV signal. However, in the Github pipeline, the fuzz tests sometimes get killed after a short amount of time. This causes that string to be printed many times (about <300). This PR relaxes the condition and allows that string to be printed 1k times before the test is considered failing.