Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline option handling #530

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Streamline option handling #530

merged 7 commits into from
Aug 10, 2023

Conversation

bertschneider
Copy link
Contributor

Options are handled in a consistent way across CLI and the Jest integration, so that both use the same names with the same semantics.

@bertschneider bertschneider force-pushed the FUZZ-694_align_parameters branch 2 times, most recently from a48c1f6 to 8d8f64f Compare August 1, 2023 07:24
@bertschneider bertschneider requested a review from a team August 1, 2023 07:44
docs/fuzz-settings.md Outdated Show resolved Hide resolved
packages/core/cli.ts Outdated Show resolved Hide resolved
packages/core/cli.ts Outdated Show resolved Hide resolved
@bertschneider bertschneider force-pushed the FUZZ-694_align_parameters branch 2 times, most recently from 53ef33c to 8424be9 Compare August 7, 2023 13:22
"clean" will delete all node_modules and dist folders, and the fuzzer
C++ build directories. Deleting all files mentioned in .gitignore files
would work even better, but there does not seem to be a still maintained
project for that.
Options are handled in a consistent way across CLI and Jest
integration, so that both use the same names with the same semantics.
Yargs automatically converts numeric CLI arguments to numbers. As the
fuzzer argument handling only expects strings, enforce the argument
types.
The additional complexity does not add any value to the test and only
prolongs the CI pipeline.
The test adds unnecessary long runtime to the CI pipeline. A more
relaxed one tests the feature good enough.
@bertschneider bertschneider merged commit f3722b3 into main Aug 10, 2023
9 checks passed
@bertschneider bertschneider deleted the FUZZ-694_align_parameters branch August 10, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants