Fix FuzzedDataProvider crash on float length #552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds checks to all functions in
FuzzedDataProvider
that accept a parameter that could be used as the number of bytes to pull from the fuzzed data. If any length value is not a whole number, the function will throw an error to preventdataPtr
from ending up a non-whole number. I chose this over having it do aMath.floor
and continuing to make clear what's going on.The crashes we were seeing were due to
consumeNumberInRange
returning a non-integer value,consumeString
would accept that value as the length of the string to get and would setthis.dataPtr
andthis._remainingBytes
as a direct calculation based off of the length given. I'm not sure whatthis.data.toString
does with the floating value but it successfully returned something so this call would work. The next call toconsumeNumberInRange
would end up trying to indexthis.data
withthis.dataPtr + <some other number>
and the end result wasthis.data[<a non-integer value>]
which JS will deal with by returningundefined
.