bugfix: prevent TypeError in the bug detectors #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oetr
force-pushed
the
FUZZ-800_bugfix_bug_detectors_type_error
branch
from
d5ef3c1
to
57f66dd
Compare
br-lewis
approved these changes
Sep 7, 2023
Yes, good point, working on it 😄 |
oetr
force-pushed
the
FUZZ-800_bugfix_bug_detectors_type_error
branch
3 times, most recently
from
83404f6
to
bd4cac3
Compare
oetr
force-pushed
the
FUZZ-800_bugfix_bug_detectors_type_error
branch
from
bd4cac3
to
bbb9cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path-traversal and command-injection bug detectors now don't throw a TypeError upon receiving arguments of the wrong type. Instead, they forward their arguments as-is to their hooked functions that can give meaningful errors.
This also extends guidance and detection support to arguments whose type is Buffer and URL for some functions hooked by the path-traversal bug detector.