Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several "build" dependencies as runtime dependencies? #642

Closed
karfau opened this issue Oct 9, 2023 · 1 comment
Closed

Several "build" dependencies as runtime dependencies? #642

karfau opened this issue Oct 9, 2023 · 1 comment

Comments

@karfau
Copy link

karfau commented Oct 9, 2023

When installing @jazzer.js/core v2.0, 63 dependencies are added.
When inspecting the graph, e.g. using https://npmgraph.js.org/?q=%40jazzer.js%2Fcore#zoom=h
i can spot at least two "areas" that look like they might not be required to run fuzz tests, since they are usually only required when "building stuff"

  • @jazzer.js/fuzzer depends on cmake-js
  • @jazzer.js/hooking and @jazzer.js/instrumentor depend on @babel/core (with tons of transient dependencies)

Are they really required to execute fuzzing or should those be devDependencies?
@oetr
Copy link
Contributor

oetr commented Oct 9, 2023

  • @babel/core: @jazzer.js/hooking does not depend on @babel/core and can be completely removed as a dependency. Good catch 👍
  • @babel/core: @jazzer.js/instrumentor needs it to work properly
  • cmake-js : in case that the target system cannot use our pre-built release, it will build our fork of libfuzzer locally

@karfau karfau closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karfau @oetr