Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for debug builds of the fuzzer #660

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

br-lewis
Copy link
Contributor

This adds a new build target to the fuzzer package, build:dev, which will build the fuzzer with a debug configuration. It also renames the prebuild target to prepack because prebuild will run prior to build which means that the call to prebuild will result in the cmake call in build seeing that things are already built and not doing anything.

While this could be handled by a prebuild:dev script that doesn't use --strip, the other problem is that prebuild (the binary, not the script), will look to see if its output tarball already exists and refuses to continue if all you've changed is the build config and no actual code. That's why I chose to have more of this process go through build and left prebuild to be part of our prerelease pipeline.

@br-lewis br-lewis requested review from a team and removed request for a team October 23, 2023 13:54
@br-lewis
Copy link
Contributor Author

Want to remove some debugging stuff before review but only after I make sure it actually passes CI.

@br-lewis br-lewis requested a review from a team October 23, 2023 14:18
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants