Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use llvm-config to set env variables #75

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Use llvm-config to set env variables #75

merged 2 commits into from
Jan 12, 2023

Conversation

bertschneider
Copy link
Contributor

No description provided.

@bertschneider bertschneider force-pushed the optimize-mac-build branch 2 times, most recently from 6ebb7e9 to 786b2c8 Compare August 22, 2022 14:20
@bertschneider bertschneider marked this pull request as draft August 22, 2022 14:50
@kyakdan
Copy link
Member

kyakdan commented Dec 6, 2022

@bertschneider Is this PR still relevant?

@bertschneider
Copy link
Contributor Author

I like the approach to use llvm-config to set all needed environment variables more than the hard coded path variant. If you also think so, we could refactor the current pipeline scripts accordingly.

@0xricksanchez
Copy link
Contributor

This looks trivial to fix and IMO brings value as hard-coding things = bad. What stops us from pushing this forward?

@kyakdan kyakdan force-pushed the optimize-mac-build branch 2 times, most recently from 0602152 to bbb7d20 Compare January 12, 2023 03:55
@kyakdan kyakdan marked this pull request as ready for review January 12, 2023 04:17
kyakdan
kyakdan approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@kyakdan kyakdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've squashed the commits and slightly adjusted resolution of CC and CXX.

@0xricksanchez 0xricksanchez merged commit 447088f into main Jan 12, 2023
@0xricksanchez 0xricksanchez deleted the optimize-mac-build branch January 12, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyakdan kyakdan kyakdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bertschneider @kyakdan @0xricksanchez